MediaWiki:CRT Search.js: Difference between revisions

Line 224:

container.innerHTML = buildHTML();

attachEventListeners();

// Load filter options, then parse URL params, then perform initial search

// URL params must be parsed AFTER filter options are loaded so that

// select dropdowns have their options populated before we try to set values

loadFilterOptions();

~~// Parse URL parameters for initial filters~~

~~parseURLParams();~~

}

Line 587:

Line 588:

Promise.all(promises).then(function() {

// First populate the select dropdowns with their options

populateSelectFilters();

// Then parse URL params - this must happen AFTER options are loaded

// so that select values can be properly set

parseURLParams();

// Finally perform the initial search with any URL-specified filters

performSearch();

});

Line 949:

Line 957:

}

/**

* Perform search with subobject conditions (inputs/mods)

* This requires a two-step query due to SMW limitations

*

* Strategy: Get all matching model names first, then paginate client-side

* to avoid hitting SMW's query size/depth limits with huge OR queries

*/

/**

* Perform search with subobject conditions (inputs/mods)

Line 1,430:

Line 1,431:

/**

* Parse URL parameters and set filters

* This must be called AFTER filter options are loaded so that

* select dropdowns have their options available

*/

function parseURLParams() {

var params = new URLSearchParams(window.location.search);

// No URL params to process

if (params.toString() === '') {

return;

}

params.forEach(function(value, key) {

Line 1,444:

Line 1,452:

}

// Find the filter

// Find the filter config

var filterConfig = null;

for (var sectionKey in FILTER_CONFIG) {

Line 1,457:

Line 1,465:

switch (filterConfig.type) {

case 'select':

var select = document.getElementById('filter-' + key);

if (select) {

// Verify the option exists before setting

var optionExists = Array.from(select.options).some(function(opt) {

return opt.value === value;

});

if (optionExists) {

select.value = value;

} else {

console.warn('Filter option not found:', key, value);

}

break;

case 'number':

var input = document.getElementById('filter-' + key);

Line 1,473:

Line 1,494:

v = v.trim();

if (!v) return;

// Check if tag already exists to avoid duplicates

var existingTag = selectedContainer.querySelector('[data-value="' + CSS.escape(v) + '"]');

if (existingTag) return;

var tag = document.createElement('span');

tag.className = 'crt-multiselect-tag';

@@ Line 224: / Line 224: @@
          container.innerHTML = buildHTML();
          attachEventListeners();
+        // Load filter options, then parse URL params, then perform initial search
+        // URL params must be parsed AFTER filter options are loaded so that
+        // select dropdowns have their options populated before we try to set values
          loadFilterOptions();
-        // Parse URL parameters for initial filters
-        parseURLParams();
      }
@@ Line 587: / Line 588: @@
          Promise.all(promises).then(function() {
+            // First populate the select dropdowns with their options
              populateSelectFilters();
+            // Then parse URL params - this must happen AFTER options are loaded
+            // so that select values can be properly set
+            parseURLParams();
+            // Finally perform the initial search with any URL-specified filters
              performSearch();
          });
@@ Line 949: / Line 957: @@
      }
-    /**
-     * Perform search with subobject conditions (inputs/mods)
-     * This requires a two-step query due to SMW limitations
-     *
-     * Strategy: Get all matching model names first, then paginate client-side
-     * to avoid hitting SMW's query size/depth limits with huge OR queries
-     */
      /**
       * Perform search with subobject conditions (inputs/mods)
@@ Line 1,430: / Line 1,431: @@
      /**
       * Parse URL parameters and set filters
+     * This must be called AFTER filter options are loaded so that
+     * select dropdowns have their options available
       */
      function parseURLParams() {
          var params = new URLSearchParams(window.location.search);
+        // No URL params to process
+        if (params.toString() === '') {
+            return;
+        }
          params.forEach(function(value, key) {
@@ Line 1,444: / Line 1,452: @@
              }
-             // Find the filter
+             // Find the filter config
              var filterConfig = null;
              for (var sectionKey in FILTER_CONFIG) {
@@ Line 1,457: / Line 1,465: @@
              switch (filterConfig.type) {
                  case 'select':
+                    var select = document.getElementById('filter-' + key);
+                    if (select) {
+                        // Verify the option exists before setting
+                        var optionExists = Array.from(select.options).some(function(opt) {
+                            return opt.value === value;
+                        });
+                        if (optionExists) {
+                            select.value = value;
+                        } else {
+                            console.warn('Filter option not found:', key, value);
+                        }
+                    }
+                    break;
                  case 'number':
                      var input = document.getElementById('filter-' + key);
@@ Line 1,473: / Line 1,494: @@
                              v = v.trim();
                              if (!v) return;
+                            // Check if tag already exists to avoid duplicates
+                            var existingTag = selectedContainer.querySelector('[data-value="' + CSS.escape(v) + '"]');
+                            if (existingTag) return;
                              var tag = document.createElement('span');
                              tag.className = 'crt-multiselect-tag';