Module:CRTBrandList: Difference between revisions

← Older edit Newer edit →

@@ Line 1: / Line 1: @@
 -- Module:CRTBrandList
 -- Dynamically generates a list of CRT brand buttons by querying
--- all unique brands from the CRT models category.
+-- pre-computed brand category pages with semantic properties.
--- Uses pagination to work around server-side SMW query limits.
+-- Much faster than scanning all CRT model pages.
 local p = {}
@@ Line 12: / Line 12: @@
 	if s == '' then return nil end
 	return s
-end
-local function extractBrandsFromResult(queryResult, brandsSet, brandsList)
-	if not queryResult then return end
-	for cellContent in queryResult:gmatch('<td[^>]*>(.-)</td>') do
-		local brand = trim(cellContent:gsub('<[^>]+>', ''))
-		if brand and brand ~= '' and not brandsSet[brand] then
-			brandsSet[brand] = true
-			table.insert(brandsList, brand)
-		end
-	end
 end
@@ Line 30: / Line 18: @@
 	local linkType = trim(args.link)
-	local brandsSet = {}
+	-- Query brand category pages (fast - only queries category pages, not all CRTs)
+	local queryWikitext =
+		'{{#ask:\n' ..
+		' [[Is CRT brand category::Yes]]\n' ..
+		' |?Brand name\n' ..
+		' |format=broadtable\n' ..
+		' |headers=hide\n' ..
+		' |link=none\n' ..
+		' |mainlabel=-\n' ..
+		' |limit=500\n' ..
+		' |searchlabel=\n' ..
+		'}}'
+	local queryResult = frame:preprocess(queryWikitext)
+	-- Extract brand names from result
 	local brandsList = {}
-	-- Query in batches to work around server-side limits
+	if queryResult then
-	local batchSize = 500
+		for cellContent in queryResult:gmatch('<td[^>]*>(.-)</td>') do
-	local maxBatches = 20  -- Safety limit: 500 * 20 = 10,000 max pages
+			local brand = trim(cellContent:gsub('<[^>]+>', ''))
+			if brand and brand ~= '' then
-	for batch = 0, maxBatches - 1 do
+				table.insert(brandsList, brand)
-		local offset = batch * batchSize
-		local queryWikitext =
-			'{{#ask:\n' ..
-			' [[Category:CRT models]]\n' ..
-			' |?Has brand\n' ..
-			' |format=broadtable\n' ..
-			' |headers=hide\n' ..
-			' |link=none\n' ..
-			' |mainlabel=-\n' ..
-			' |limit=' .. batchSize .. '\n' ..
-			' |offset=' .. offset .. '\n' ..
-			' |searchlabel=\n' ..
-			'}}'
-		local queryResult = frame:preprocess(queryWikitext)
-		-- Count results in this batch
-		local countBefore = #brandsList
-		extractBrandsFromResult(queryResult, brandsSet, brandsList)
-		-- Check if we got any new results (not just new unique brands)
-		-- If the result is empty or very small, we've reached the end
-		local cellCount = 0
-		if queryResult then
-			for _ in queryResult:gmatch('<td[^>]*>') do
-				cellCount = cellCount + 1
 			end
-		end
-		-- If we got fewer results than batch size, we're done
-		if cellCount < batchSize then
-			break
 		end
 	end