Module:CRTBrandList: Difference between revisions

(One intermediate revision by the same user not shown)

Line 1:

-- Module:CRTBrandList

-- Dynamically generates a list of CRT brand buttons by querying

-- ~~distinct brands from actual CRT model~~ pages.

-- pre-computed brand category pages with semantic properties.

-- ~~This approach ensures~~ all ~~brands with at least one~~ CRT model ~~appear,~~

-- Much faster than scanning all CRT model pages.

~~-- even if they don't have a dedicated brand category page~~.

local p = {}

Line 19:

Line 18:

local linkType = trim(args.link)

-- Query ~~distinct brands from actual CRT model~~ pages

-- Query brand category pages (fast - only queries category pages, not all CRTs)

local queryWikitext =

'{{#ask:\n' ..

' [[~~Category:~~CRT ~~models]]\n' ..~~

' [[Is CRT brand category::Yes]]\n' ..

~~' [[Has~~ brand::+]]\n' ..

' |?Brand name\n' ..

' |?~~Has brand~~\n' ..

' |format=broadtable\n' ..

' |headers=hide\n' ..

' |link=none\n' ..

' |mainlabel=-\n' ..

' |limit=~~5000~~\n' ..

' |limit=500\n' ..

' |searchlabel=\n' ..

'}}'

Line 35:

Line 33:

local queryResult = frame:preprocess(queryWikitext)

-- Extract ~~and deduplicate~~ brand names from result

-- Extract brand names from result

~~local seen = {}~~

local brandsList = {}

Line 42:

Line 39:

for cellContent in queryResult:gmatch('<td[^>]*>(.-)</td>') do

local brand = trim(cellContent:gsub('<[^>]+>', ''))

if brand and brand ~= '' ~~and not seen[brand]~~ then

if brand and brand ~= '' then

~~seen[brand] = true~~

table.insert(brandsList, brand)

end

@@ Line 1: / Line 1: @@
 -- Module:CRTBrandList
 -- Dynamically generates a list of CRT brand buttons by querying
--- distinct brands from actual CRT model pages.
+-- pre-computed brand category pages with semantic properties.
--- This approach ensures all brands with at least one CRT model appear,
+-- Much faster than scanning all CRT model pages.
--- even if they don't have a dedicated brand category page.
 local p = {}
@@ Line 19: / Line 18: @@
 	local linkType = trim(args.link)
-	-- Query distinct brands from actual CRT model pages
+	-- Query brand category pages (fast - only queries category pages, not all CRTs)
 	local queryWikitext =
 		'{{#ask:\n' ..
-		' [[Category:CRT models]]\n' ..
+		' [[Is CRT brand category::Yes]]\n' ..
-		' [[Has brand::+]]\n' ..
+		' |?Brand name\n' ..
-		' |?Has brand\n' ..
 		' |format=broadtable\n' ..
 		' |headers=hide\n' ..
 		' |link=none\n' ..
 		' |mainlabel=-\n' ..
-		' |limit=5000\n' ..
+		' |limit=500\n' ..
 		' |searchlabel=\n' ..
 		'}}'
@@ Line 35: / Line 33: @@
 	local queryResult = frame:preprocess(queryWikitext)
-	-- Extract and deduplicate brand names from result
+	-- Extract brand names from result
-	local seen = {}
 	local brandsList = {}
@@ Line 42: / Line 39: @@
 		for cellContent in queryResult:gmatch('<td[^>]*>(.-)</td>') do
 			local brand = trim(cellContent:gsub('<[^>]+>', ''))
-			if brand and brand ~= '' and not seen[brand] then
+			if brand and brand ~= '' then
-				seen[brand] = true
 				table.insert(brandsList, brand)
 			end